Open compact tool tabs as full-page surfaces - #2762
Merged
brsbl merged 5 commits intoSep 1, 2026
Merged
Conversation
brsbl
marked this pull request as ready for review
August 31, 2026 05:56
This was referenced Aug 31, 2026
brsbl
force-pushed
the
bb/compact-tool-tabs-full-page-thr_wftu7bh9ez
branch
from
September 1, 2026 04:41
6456527 to
0f50516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
After the right panel became a shelf, every tab remained constrained to 298.67px. Selecting New Tab could update the tab strip while leaving Info content visible, so tool surfaces did not receive a usable phone-width canvas. A newly created terminal could also lose its persisted active selection while the terminal list caught up, causing the settled tab to fall back to the shelf.
What changed
Compact presentation rules
The opener only selects or restores a tab. The active tab kind determines the panel geometry, and switching tabs changes that geometry immediately.
thread-info)No mobile-home, navigation-feedback, provider-cache, or base shelf behavior changes in this layer.
How you verified
108402ee09e4a70b2df61542e7054ce73fae924aand capture headfb9902ab803b381574252195d4980b937d9405c4. The final layer is exact base8bd201435a25ce4feb3579a5fe3b9fa84d22e4b6and exact head0f50516ccab03168a1730e62d05c65b512405571; it inherits the square-pane rollback without changing this layer’s full-page tab policy.Start terminaland waited for the realzshtab and xterm subtree to settle with zero panel skeletons./projects/proj_m65y3vujaj/threads/thr_done, using one realistic environment-backed fixture, the same persistedAppPageHeader.tsxtab, the same populated Recent item, and the same viewport for both current-head captures. Only the active tab changed.Hide right panelcontrol remained visible.Hide right panel, with the fixed left trigger absent from the DOM and focus order. New Tab preserved the same one-control ownership while full-page. Closing either right surface restored the left trigger; opening the left shelf left only that trigger on screen and kept the right surface closed.thread-storage/files; the rendered production empty states and panel interactions remained valid. Remote CI passed tests, typecheck, lint, both package smokes, and version gates on the exact final head. No local CI-equivalent command was run.Populated feature evidence at the preceding head
These captures retain the realistic populated fixture from the preceding feature head. They prove the Info shelf exception and the New Tab full-page policy with production content.
Exact final head: one owning control
Chrome for Testing 151.0.7922.71 captured both states in one session on
/projects/proj_m65y3vujaj/threads/thr_doneat 390×844 CSS px. The route, fixture, viewport, and open right-panel interaction stayed fixed; only the active Info versus New Tab destination changed. Both are production panel surfaces, and neither capture contains a loading skeleton.Original base/head width regression
This historical pair remains the original feature regression; the current-head pair above is the final-branch evidence.
BB-Thread-ID: thr_wftu7bh9ez